Re: [PATCH net 1/5] net sched actions: fix coding style in pedit action
From: Davide Caratti <hidden>
Date: 2018-06-20 12:29:46
On Tue, 2018-06-19 at 12:56 -0400, Roman Mashak wrote:
Fix coding style issues in tc pedit action detected by the checkpatch script. Signed-off-by: Roman Mashak <redacted>
...
quoted hunk ↗ jump to hunk
---@@ -316,16 +318,15 @@ static int tcf_pedit(struct sk_buff *skb, const struct tc_action *a, hoffset + tkey->at); goto bad; } - d = skb_header_pointer(skb, hoffset + tkey->at, 1, - &_d); + d = skb_header_pointer(skb, hoffset + tkey->at, + 1, &_d);if (!d) goto bad; offset += (*d & tkey->offmask) >> tkey->shift; }
hello Roman, nit: while we are here, what about changing the declaration of _d and *d to u8, so that the bitwise operation is done on unsigned? BTW: the patch (and the series) looks ok, but I guess it will better target net-next when the branch reopens thanks! -- davide