Thread (11 messages) flat view 11 messages, 4 authors, 2018-06-20

Re: [PATCH net 5/5] net sched actions: fix misleading text strings in pedit action

From: Roman Mashak <hidden>
Date: 2018-06-19 17:15:54

Stephen Hemminger [off-list ref] writes:
On Tue, 19 Jun 2018 12:56:08 -0400
[...]
quoted
@@ -326,12 +326,12 @@ static int tcf_pedit(struct sk_buff *skb, const struct tc_action *a,
 			}
 
 			if (offset % 4) {
-				pr_info("tc filter pedit offset must be on 32 bit boundaries\n");
+				pr_info("tc action pedit offset must be on 32 bit boundaries\n");
 				goto bad;
 			}
 
 			if (!offset_valid(skb, hoffset + offset)) {
-				pr_info("tc filter pedit offset %d out of bounds\n",
+				pr_info("tc action pedit offset %d out of bounds\n",
 					hoffset + offset);
 				goto bad;
Time to convert these to netlink extack reporting?
Yes, this is planned in next patches.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help