Re: [PATCH net] failover: eliminate callback hell

From
Samudrala, Sridhar <sridhar.samudrala@intel.com>
Date
2018-06-12 00:08:32
Reply to
Samudrala, Sridhar, 2018-06-11
On 6/11/2018 12:34 PM, Samudrala, Sridhar wrote:
On 6/11/2018 11:10 AM, Michael S. Tsirkin wrote:
quoted
On Mon, Jun 04, 2018 at 08:42:31PM -0700, Stephen Hemminger wrote:
quoted
   * Set permanent and current address of net_failover device
     to match the primary.
We copy the dev_addr of standby dev to failover_dev in net_failover_create()
before calling register_netdev().
register_netdev() does a copy of dev_addr to perm_addr.

So i don't think this is an issue.
quoted
quoted
   * Carrier should be marked off before registering device
     the net_failover device.
Will fix this and also a couple of places dev_err() needs to be replaced with netdev_err()
quoted
Sridhar, do we want to address this?
If yes, could you please take a look at addressing these
meanwhile, while we keep arguing about making API changes?
Sure. I will submit patches to address these issues raised by Stephen.
Thread (52 messages) 52 messages, 8 authors, last reply 2018-06-12
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help