Re: [PATCH net] failover: eliminate callback hell

From
Stephen Hemminger <stephen@networkplumber.org>
Date
2018-06-06 21:26:33
Reply to
Jiri Pirko, 2018-06-06
On Wed, 6 Jun 2018 09:25:12 +0200
Jiri Pirko [off-list ref] wrote:
Tue, Jun 05, 2018 at 05:42:31AM CEST, stephen@networkplumber.org wrote:
quoted
The net failover should be a simple library, not a virtual
object with function callbacks (see callback hell).  
Why just a library? It should do a common things. I think it should be a
virtual object. Looks like your patch again splits the common
functionality into multiple drivers. That is kind of backwards attitude.
I don't get it. We should rather focus on fixing the mess the
introduction of netvsc-bonding caused and switch netvsc to 3-netdev
model.
To me, callbacks are worse than a simple notifier. Is there some other
agenda going on? do you want to get rid of network notifier.

Netvsc is not switching to 3 device model in near future.
Too much userspace is wrapped around it already.
Thread (52 messages) 52 messages, 8 authors, last reply 2018-06-12
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help