Thread (32 messages) 32 messages, 6 authors, 2018-05-14

Re: [PATCH net-next v2 03/13] net: phy: sfp: warn the user when no tx_disable pin is available

From: Florian Fainelli <f.fainelli@gmail.com>
Date: 2018-05-04 17:07:59
Also in: linux-arm-kernel, lkml

On 05/04/2018 06:56 AM, Antoine Tenart wrote:
In case no Tx disable pin is available the SFP modules will always be
emitting. This could be an issue when using modules using laser as their
light source as we would have no way to disable it when the fiber is
removed. This patch adds a warning when registering an SFP cage which do
not have its tx_disable pin wired or available.
Is this something that was done in a possibly earlier revision of a
given board design and which was finally fixed? Nothing wrong with the
patch, but this seems like a pretty serious board design mistake, that
needs to be addressed.
-- 
Florian
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help