Re: simplify procfs code for seq_file instances V2

simplify procfs code for seq_file instances V2 · Christoph Hellwig <hch@lst.de> · 2018-04-25
[PATCH 01/40] net/can: single_open_net needs to be paired with single_release_net · Christoph Hellwig <hch@lst.de> · 2018-04-25
[PATCH 02/40] proc: simplify proc_register calling conventions · Christoph Hellwig <hch@lst.de> · 2018-04-25
[PATCH 03/40] proc: add a proc_create_reg helper · Christoph Hellwig <hch@lst.de> · 2018-04-25
[PATCH 04/40] proc: introduce proc_create_seq{,_data} · Christoph Hellwig <hch@lst.de> · 2018-04-25
Re: [PATCH 04/40] proc: introduce proc_create_seq{,_data} · David Howells <dhowells@redhat.com> · 2018-04-30
Re: [PATCH 04/40] proc: introduce proc_create_seq{,_data} · Christoph Hellwig <hch@lst.de> · 2018-05-15
[PATCH 05/40] proc: introduce proc_create_seq_private · Christoph Hellwig <hch@lst.de> · 2018-04-25
[PATCH 06/40] proc: introduce proc_create_single{,_data} · Christoph Hellwig <hch@lst.de> · 2018-04-25
Re: [PATCH 06/40] proc: introduce proc_create_single{,_data} · Finn Thain <hidden> · 2018-04-26
Re: [PATCH 06/40] proc: introduce proc_create_single{,_data} · Christoph Hellwig <hch@lst.de> · 2018-05-15
[PATCH 07/40] ipv{4,6}/udp{,lite}: simplify proc registration · Christoph Hellwig <hch@lst.de> · 2018-04-25
[PATCH 08/40] ipv{4,6}/tcp: simplify procfs registration · Christoph Hellwig <hch@lst.de> · 2018-04-25
[PATCH 09/40] ipv{4,6}/ping: simplify proc file creation · Christoph Hellwig <hch@lst.de> · 2018-04-25
[PATCH 10/40] =?UTF-8?q?ipv{4, 6}/raw:=20simplify=20=D1=95eq=5Ffil?= e code · Christoph Hellwig <hch@lst.de> · 2018-04-25
[PATCH 11/40] ipv6/flowlabel: simplify pid namespace lookup · Christoph Hellwig <hch@lst.de> · 2018-04-25
[PATCH 12/40] net/kcm: simplify proc registration · Christoph Hellwig <hch@lst.de> · 2018-04-25
[PATCH 13/40] netfilter/x_tables: simplify ѕeq_file code · Christoph Hellwig <hch@lst.de> · 2018-04-25
[PATCH 14/40] net: move seq_file_single_net to <linux/seq_file_net.h> · Christoph Hellwig <hch@lst.de> · 2018-04-25
[PATCH 15/40] proc: introduce proc_create_net{,_data} · Christoph Hellwig <hch@lst.de> · 2018-04-25
[PATCH 16/40] proc: introduce proc_create_net_single · Christoph Hellwig <hch@lst.de> · 2018-04-25
[PATCH 17/40] acpi/battery: simplify procfs code · Christoph Hellwig <hch@lst.de> · 2018-04-25
[PATCH 18/40] sgi-gru: simplify procfs code · Christoph Hellwig <hch@lst.de> · 2018-04-25
[PATCH 19/40] megaraid: simplify procfs code · Christoph Hellwig <hch@lst.de> · 2018-04-25
[PATCH 20/40] sg: simplify procfs code · Christoph Hellwig <hch@lst.de> · 2018-04-25
[PATCH 21/40] afs: simplify procfs code · Christoph Hellwig <hch@lst.de> · 2018-04-25
[PATCH 22/40] ext4: simplify procfs code · Christoph Hellwig <hch@lst.de> · 2018-04-25
[PATCH 23/40] jfs: simplify procfs code · Christoph Hellwig <hch@lst.de> · 2018-04-25
[PATCH 24/40] staging/rtl8192u: simplify procfs code · Christoph Hellwig <hch@lst.de> · 2018-04-25
[PATCH 25/40] resource: switch to proc_create_seq_data · Christoph Hellwig <hch@lst.de> · 2018-04-25
[PATCH 26/40] drbd: switch to proc_create_single · Christoph Hellwig <hch@lst.de> · 2018-04-25
[PATCH 27/40] rtc/proc: switch to proc_create_single_data · Christoph Hellwig <hch@lst.de> · 2018-04-25
Re: [PATCH 27/40] rtc/proc: switch to proc_create_single_data · Alexandre Belloni <alexandre.belloni@bootlin.com> · 2018-04-25
[PATCH 28/40] bonding: switch to proc_create_seq_data · Christoph Hellwig <hch@lst.de> · 2018-04-25
[PATCH 29/40] hostap: switch to proc_create_{seq,single}_data · Christoph Hellwig <hch@lst.de> · 2018-04-25
[PATCH 30/40] neigh: switch to proc_create_seq_data · Christoph Hellwig <hch@lst.de> · 2018-04-25
[PATCH 31/40] netfilter/xt_hashlimit: switch to proc_create_{seq, single}_data · Christoph Hellwig <hch@lst.de> · 2018-04-25
[PATCH 32/40] netfilter/x_tables: switch to proc_create_seq_private · Christoph Hellwig <hch@lst.de> · 2018-04-25
[PATCH 33/40] bluetooth: switch to proc_create_seq_data · Christoph Hellwig <hch@lst.de> · 2018-04-25
[PATCH 34/40] atm: simplify procfs code · Christoph Hellwig <hch@lst.de> · 2018-04-25
[PATCH 35/40] atm: switch to proc_create_seq_private · Christoph Hellwig <hch@lst.de> · 2018-04-25
[PATCH 36/40] isdn: replace ->proc_fops with ->proc_show · Christoph Hellwig <hch@lst.de> · 2018-04-25
[PATCH 37/40] proc: don't detour through seq->private to get the inode · Christoph Hellwig <hch@lst.de> · 2018-04-25
[PATCH 38/40] ide: remove ide_driver_proc_write · Christoph Hellwig <hch@lst.de> · 2018-04-25
[PATCH 39/40] ide: replace ->proc_fops with ->proc_show · Christoph Hellwig <hch@lst.de> · 2018-04-25
[PATCH 40/40] tty: replace ->proc_fops with ->proc_show · Christoph Hellwig <hch@lst.de> · 2018-04-25
Re: simplify procfs code for seq_file instances V2 · David Howells <dhowells@redhat.com> · 2018-04-30
Re: simplify procfs code for seq_file instances V2 · Alexey Dobriyan <hidden> · 2018-05-06
Re: simplify procfs code for seq_file instances V2 · Al Viro <viro@ZenIV.linux.org.uk> · 2018-05-06
Re: simplify procfs code for seq_file instances V2 · Alexey Dobriyan <hidden> · 2018-05-09
Re: simplify procfs code for seq_file instances V2 · Christoph Hellwig <hch@lst.de> · 2018-05-15

From: Christoph Hellwig <hidden>
Date: 2018-05-15 14:03:26
Also in: linux-acpi, linux-ext4, linux-ide, linux-rtc, linux-scsi, lkml, netfilter-devel

On Sun, May 06, 2018 at 08:19:49PM +0300, Alexey Dobriyan wrote:

On Wed, Apr 25, 2018 at 05:47:47PM +0200, Christoph Hellwig wrote:

quoted

Changes since V1:
 - open code proc_create_data to avoid setting not fully initialized
   entries live
 - use unsigned int for state_size

Need this to maintain sizeof(struct proc_dir_entry):

I'll fold your changes into the relevant patches.

Otherwise ACK fs/proc/ part.

I'll take this as a formal ACK-ed by for all patches touching
procfs.  If I was wrong please scream.

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help