On Mon, Apr 30, 2018 at 02:19:25PM +0100, David Howells wrote:

Christoph Hellwig [off-list ref] wrote:

quoted

+
+struct proc_dir_entry *proc_create_seq_data(const char *name, umode_t mode,
+		struct proc_dir_entry *parent, const struct seq_operations *ops,
+		void *data)
+{
...
+EXPORT_SYMBOL(proc_create_seq_data);

Please add documentation comments to exported functions when you add them.

None of the base functions are document, and we really want people to not
use procfs for new code anyway.  But if I get some consensus from the
maintainers and the list I can throw in another patch to document
all proc_create* variants.