Re: [PATCH 41/42] tty: replace ->proc_fops with ->proc_show

simplify procfs code for seq_file instances V3 · Christoph Hellwig <hch@lst.de> · 2018-05-16
[PATCH 01/42] net/can: single_open_net needs to be paired with single_release_net · Christoph Hellwig <hch@lst.de> · 2018-05-16
[PATCH 02/42] proc: introduce a proc_pid_ns helper · Christoph Hellwig <hch@lst.de> · 2018-05-16
[PATCH 03/42] proc: don't detour through seq->private to get the inode · Christoph Hellwig <hch@lst.de> · 2018-05-16
[PATCH 04/42] proc: simplify proc_register calling conventions · Christoph Hellwig <hch@lst.de> · 2018-05-16
[PATCH 05/42] proc: add a proc_create_reg helper · Christoph Hellwig <hch@lst.de> · 2018-05-16
[PATCH 06/42] proc: introduce proc_create_seq{,_data} · Christoph Hellwig <hch@lst.de> · 2018-05-16
[PATCH 07/42] proc: introduce proc_create_seq_private · Christoph Hellwig <hch@lst.de> · 2018-05-16
[PATCH 08/42] proc: introduce proc_create_single{,_data} · Christoph Hellwig <hch@lst.de> · 2018-05-16
[PATCH 09/42] ipv{4,6}/udp{,lite}: simplify proc registration · Christoph Hellwig <hch@lst.de> · 2018-05-16
[PATCH 10/42] ipv{4,6}/tcp: simplify procfs registration · Christoph Hellwig <hch@lst.de> · 2018-05-16
[PATCH 11/42] ipv{4,6}/ping: simplify proc file creation · Christoph Hellwig <hch@lst.de> · 2018-05-16
[PATCH 12/42] =?UTF-8?q?ipv{4, 6}/raw:=20simplify=20=D1=95eq=5Ffil?= e code · Christoph Hellwig <hch@lst.de> · 2018-05-16
[PATCH 13/42] ipv6/flowlabel: simplify pid namespace lookup · Christoph Hellwig <hch@lst.de> · 2018-05-16
[PATCH 14/42] net/kcm: simplify proc registration · Christoph Hellwig <hch@lst.de> · 2018-05-16
[PATCH 15/42] netfilter/x_tables: simplify ѕeq_file code · Christoph Hellwig <hch@lst.de> · 2018-05-16
[PATCH 16/42] net: move seq_file_single_net to <linux/seq_file_net.h> · Christoph Hellwig <hch@lst.de> · 2018-05-16
[PATCH 17/42] proc: introduce proc_create_net{,_data} · Christoph Hellwig <hch@lst.de> · 2018-05-16
[PATCH 18/42] proc: introduce proc_create_net_single · Christoph Hellwig <hch@lst.de> · 2018-05-16
[PATCH 19/42] acpi/battery: simplify procfs code · Christoph Hellwig <hch@lst.de> · 2018-05-16
[PATCH 20/42] sgi-gru: simplify procfs code · Christoph Hellwig <hch@lst.de> · 2018-05-16
[PATCH 21/42] megaraid: simplify procfs code · Christoph Hellwig <hch@lst.de> · 2018-05-16
[PATCH 22/42] sg: simplify procfs code · Christoph Hellwig <hch@lst.de> · 2018-05-16
[PATCH 23/42] afs: simplify procfs code · Christoph Hellwig <hch@lst.de> · 2018-05-16
[PATCH 24/42] ext4: simplify procfs code · Christoph Hellwig <hch@lst.de> · 2018-05-16
[PATCH 25/42] jfs: simplify procfs code · Christoph Hellwig <hch@lst.de> · 2018-05-16
Re: [Jfs-discussion] [PATCH 25/42] jfs: simplify procfs code · Dave Kleikamp <hidden> · 2018-05-16
[PATCH 26/42] staging/rtl8192u: simplify procfs code · Christoph Hellwig <hch@lst.de> · 2018-05-16
[PATCH 27/42] resource: switch to proc_create_seq_data · Christoph Hellwig <hch@lst.de> · 2018-05-16
[PATCH 28/42] drbd: switch to proc_create_single · Christoph Hellwig <hch@lst.de> · 2018-05-16
Re: [Drbd-dev] [PATCH 28/42] drbd: switch to proc_create_single · Lars Ellenberg <lars.ellenberg@linbit.com> · 2018-05-18
[PATCH 29/42] rtc/proc: switch to proc_create_single_data · Christoph Hellwig <hch@lst.de> · 2018-05-16
[PATCH 30/42] bonding: switch to proc_create_seq_data · Christoph Hellwig <hch@lst.de> · 2018-05-16
[PATCH 31/42] hostap: switch to proc_create_{seq,single}_data · Christoph Hellwig <hch@lst.de> · 2018-05-16
[PATCH 32/42] neigh: switch to proc_create_seq_data · Christoph Hellwig <hch@lst.de> · 2018-05-16
[PATCH 33/42] netfilter/xt_hashlimit: switch to proc_create_{seq, single}_data · Christoph Hellwig <hch@lst.de> · 2018-05-16
[PATCH 34/42] netfilter/x_tables: switch to proc_create_seq_private · Christoph Hellwig <hch@lst.de> · 2018-05-16
[PATCH 35/42] bluetooth: switch to proc_create_seq_data · Christoph Hellwig <hch@lst.de> · 2018-05-16
[PATCH 36/42] atm: simplify procfs code · Christoph Hellwig <hch@lst.de> · 2018-05-16
[PATCH 37/42] atm: switch to proc_create_seq_private · Christoph Hellwig <hch@lst.de> · 2018-05-16
[PATCH 38/42] isdn: replace ->proc_fops with ->proc_show · Christoph Hellwig <hch@lst.de> · 2018-05-16
Re: [PATCH 38/42] isdn: replace ->proc_fops with ->proc_show · Paul Bolle <hidden> · 2018-05-18
Re: [PATCH 38/42] isdn: replace ->proc_fops with ->proc_show · Christoph Hellwig <hch@lst.de> · 2018-05-18
[PATCH 39/42] ide: remove ide_driver_proc_write · Christoph Hellwig <hch@lst.de> · 2018-05-16
[PATCH 40/42] ide: replace ->proc_fops with ->proc_show · Christoph Hellwig <hch@lst.de> · 2018-05-16
[PATCH 41/42] tty: replace ->proc_fops with ->proc_show · Christoph Hellwig <hch@lst.de> · 2018-05-16
Re: [PATCH 41/42] tty: replace ->proc_fops with ->proc_show · Greg Kroah-Hartman <gregkh@linuxfoundation.org> · 2018-05-16
[PATCH 42/42] proc: update SIZEOF_PDE_INLINE_NAME for the new pde fields · Christoph Hellwig <hch@lst.de> · 2018-05-16
Re: simplify procfs code for seq_file instances V3 · Al Viro <viro@ZenIV.linux.org.uk> · 2018-05-16

From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: 2018-05-16 09:58:02
Also in: linux-acpi, linux-ext4, linux-ide, linux-rtc, linux-scsi, lkml, netfilter-devel

On Wed, May 16, 2018 at 11:43:45AM +0200, Christoph Hellwig wrote:

Just set up the show callback in the tty_operations, and use
proc_create_single_data to create the file without additional
boilerplace code.

Signed-off-by: Christoph Hellwig <hch@lst.de>

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help