On Wed, May 16, 2018 at 11:43:32AM +0200, Christoph Hellwig wrote:

And stop messing with try_module_get on THIS_MODULE, which doesn't make
any sense here.

The idea was to increase module count on /proc/drbd access.

If someone holds /proc/drbd open, previously rmmod would
"succeed" in starting the unload, but then block on remove_proc_entry,
leading to a situation where the lsmod does not show drbd anymore,
but /proc/drbd being still there (but no longer accessible).

I'd rather have rmmod fail up front in this case.
And try_module_get() seemed most appropriate.

    Lars