Re: [PATCH net-next v11 2/5] netvsc: refactor notifier/event handling code to use the failover framework
From: "Michael S. Tsirkin" <mst@redhat.com>
Date: 2018-05-22 19:54:35
From: "Michael S. Tsirkin" <mst@redhat.com>
Date: 2018-05-22 19:54:35
On Tue, May 22, 2018 at 07:38:44PM +0200, Jiri Pirko wrote:
quoted
quoted
quoted
quoted
In private flag. I don't see no reason to break this pattern here.Other masters are setup from userspace, this one is set up automatically by kernel. So the bar is higher, we need an interface that existing userspace knows about. We can't just say "oh if userspace set this up it should know to skip lowerdevs". Otherwise multiple interfaces with same mac tend to confuse userspace.No difference, really. Regardless who does the setup, and independent userspace deamon should react accordingly.If the deamon does the setup itself, it's reasonable to require that it learns about new flags each time we add a new driver. If it doesn't, then I think it's less reasonable.No need. The "IFLA_MASTER" attr is always there to be looked at. That is enough.
Oh so if it has an master, skip it? Sorry, I misunderstood what you were saying earlier. Thanks, this makes sense to me. -- MST