Thread (28 messages) 28 messages, 4 authors, 2018-03-16

Re: [PATCH 2/7] ixgbe: eliminate duplicate barriers on weakly-ordered archs

flat view

From: Alexander Duyck <hidden>
Date: 2018-03-15 01:47:27
Also in: intel-wired-lan, linux-arm-kernel, linux-arm-msm, lkml

On Tue, Mar 13, 2018 at 8:20 PM, Sinan Kaya [off-list ref] wrote:
Code includes wmb() followed by writel() in multiple places. writel()
already has a barrier on some architectures like arm64.

This ends up CPU observing two barriers back to back before executing the
register write.

Since code already has an explicit barrier call, changing writel() to
writel_relaxed().

Signed-off-by: Sinan Kaya <redacted>
In this patch you missed the writel at the end of ixgbe_tx_map.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help