Re: [PATCH 7/7] ixgbevf: eliminate duplicate barriers on weakly-ordered archs
flat view
From: Timur Tabi <hidden>
Date: 2018-03-14 05:08:56
Also in:
intel-wired-lan, linux-arm-kernel, linux-arm-msm, lkml
On 3/13/18 10:20 PM, Sinan Kaya wrote:
quoted hunk ↗ jump to hunk
+/* Assumes caller has executed a write barrier to order memory and device + * requests. + */ static inline void ixgbevf_write_tail(struct ixgbevf_ring *ring, u32 value) { - writel(value, ring->tail); + writel_relaxed(value, ring->tail); }
Why not put the wmb() in this function, or just get rid of the wmb() in the rest of the file and keep this as writel? That way, you can avoid the comment and the risk that comes with it. -- Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.