Re: [PATCH v2 08/21] iio: adc: Remove depends on HAS_DMA in case of platform dependency
From: Jonathan Cameron <jic23@kernel.org>
Date: 2018-03-17 16:42:41
Also in:
alsa-devel, linux-crypto, linux-fpga, linux-i2c, linux-ide, linux-iommu, linux-mmc, linux-remoteproc, linux-scsi, linux-serial, linux-spi, lkml
On Fri, 16 Mar 2018 14:51:41 +0100 Geert Uytterhoeven [off-list ref] wrote:
Remove dependencies on HAS_DMA where a Kconfig symbol depends on another symbol that implies HAS_DMA, and, optionally, on "|| COMPILE_TEST". In most cases this other symbol is an architecture or platform specific symbol, or PCI. Generic symbols and drivers without platform dependencies keep their dependencies on HAS_DMA, to prevent compiling subsystems or drivers that cannot work anyway. This simplifies the dependencies, and allows to improve compile-testing. Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> Reviewed-by: Mark Brown <broonie@kernel.org> Acked-by: Robin Murphy <robin.murphy@arm.com>
Great. Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> Thanks for doing this - this has been annoying for a long time :)
quoted hunk ↗ jump to hunk
--- v2: - Add Reviewed-by, Acked-by, - Drop RFC state, - Split per subsystem. --- drivers/iio/adc/Kconfig | 2 -- 1 file changed, 2 deletions(-)diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig index 72bc2b71765ae2ff..57f46e88f5c2536e 100644 --- a/drivers/iio/adc/Kconfig +++ b/drivers/iio/adc/Kconfig@@ -158,7 +158,6 @@ config AT91_SAMA5D2_ADC tristate "Atmel AT91 SAMA5D2 ADC" depends on ARCH_AT91 || COMPILE_TEST depends on HAS_IOMEM - depends on HAS_DMA select IIO_TRIGGERED_BUFFER help Say yes here to build support for Atmel SAMA5D2 ADC which is@@ -647,7 +646,6 @@ config SD_ADC_MODULATOR config STM32_ADC_CORE tristate "STMicroelectronics STM32 adc core" depends on ARCH_STM32 || COMPILE_TEST - depends on HAS_DMA depends on OF depends on REGULATOR select IIO_BUFFER