RE: [PATCH v2 10/21] lightnvm: Remove depends on HAS_DMA in case of platform dependency
From: Madalin-cristian Bucur <hidden>
Date: 2018-03-19 05:27:16
Also in:
alsa-devel, linux-block, linux-crypto, linux-fbdev, linux-fpga, linux-i2c, linux-ide, linux-iio, linux-iommu, linux-media, linux-mmc, linux-remoteproc, linux-scsi, linux-serial, linux-spi, linux-usb, lkml
-----Original Message-----
From: netdev-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org [mailto:netdev-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org]
On Behalf Of Geert Uytterhoeven
Sent: Friday, March 16, 2018 3:52 PM
To: Christoph Hellwig <redacted>; Marek Szyprowski
[off-list ref]; Robin Murphy [off-list ref];
Felipe Balbi [off-list ref]; Greg Kroah-Hartman
[off-list ref]; James E . J . Bottomley
[off-list ref]; Martin K . Petersen
[off-list ref]; Andrew Morton <akpm@linux-
foundation.org>; Mark Brown [off-list ref]; Liam Girdwood
[off-list ref]; Tejun Heo [off-list ref]; Herbert Xu
[off-list ref]; David S . Miller [off-list ref];
Bartlomiej Zolnierkiewicz [off-list ref]; Stefan Richter
[off-list ref]; Alan Tull [off-list ref]; Moritz Fischer
[off-list ref]; Wolfram Sang [off-list ref]; Jonathan Cameron
[off-list ref]; Joerg Roedel [off-list ref]; Matias Bjorling
[off-list ref]; Jassi Brar [off-list ref]; Mauro Carvalho
Chehab [off-list ref]; Ulf Hansson [off-list ref]; David
Woodhouse [off-list ref]; Brian Norris
[off-list ref]; Marek Vasut [off-list ref];
Cyrille Pitchen [off-list ref]; Boris Brezillon
[off-list ref]; Richard Weinberger [off-list ref];
Kalle Valo [off-list ref]; Ohad Ben-Cohen [off-list ref];
Bjorn Andersson [off-list ref]; Eric Anholt [off-list ref];
Stefan Wahren [off-list ref]
Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org; linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linux-
scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org; linux-ide-u79uwXL29TY76Z2rM5mHXA@public.gmane.org;
linux-crypto-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linux1394-
devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org; linux-fpga-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linux-
i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org;
linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linux-
mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org; netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linux-
remoteproc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linux-
spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b@public.gmane.org; linux-
kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; Geert Uytterhoeven [off-list ref]
Subject: [PATCH v2 10/21] lightnvm: Remove depends on HAS_DMA in case of
platform dependency
Remove dependencies on HAS_DMA where a Kconfig symbol depends on
another
symbol that implies HAS_DMA, and, optionally, on "|| COMPILE_TEST".
In most cases this other symbol is an architecture or platform specific
symbol, or PCI.
Generic symbols and drivers without platform dependencies keep their
dependencies on HAS_DMA, to prevent compiling subsystems or drivers that
cannot work anyway.
This simplifies the dependencies, and allows to improve compile-testing.
Notes:
- FSL_FMAN keeps its dependency on HAS_DMA, as it calls set_dma_ops(),
which does not exist if HAS_DMA=n (Do we need a dummy? The use of
set_dma_ops() in this driver is questionable),Hi, The set_dma_ops() is no longer required in the fsl/fman, I'll send a patch to remove it. Thanks
quoted hunk ↗ jump to hunk
- SND_SOC_LPASS_IPQ806X and SND_SOC_LPASS_PLATFORM loose their dependency on HAS_DMA, as they are selected from SND_SOC_APQ8016_SBC. Signed-off-by: Geert Uytterhoeven <redacted> Reviewed-by: Mark Brown <redacted> Acked-by: Robin Murphy <redacted> --- v2: - Add Reviewed-by, Acked-by, - Drop RFC state, - Split per subsystem. --- drivers/lightnvm/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/lightnvm/Kconfig b/drivers/lightnvm/Kconfig index 10c08982185a572f..9c03f35d9df113c6 100644 --- a/drivers/lightnvm/Kconfig +++ b/drivers/lightnvm/Kconfig@@ -4,7 +4,7 @@ menuconfig NVM bool "Open-Channel SSD target support" - depends on BLOCK && HAS_DMA && PCI + depends on BLOCK && PCI select BLK_DEV_NVME help Say Y here to get to enable Open-channel SSDs. --2.7.4