Re: [PATCH RFC net-next 7/7] netdevsim: Add simple FIB resource controller via devlink

On 3/25/18 12:35 AM, Jakub Kicinski wrote:

On Sat, 24 Mar 2018 09:02:45 -0600, David Ahern wrote:

quoted

quoted

quoted

diff --git a/drivers/net/netdevsim/Makefile b/drivers/net/netdevsim/Makefile
index 09388c06171d..449b2a1a1800 100644
--- a/drivers/net/netdevsim/Makefile
+++ b/drivers/net/netdevsim/Makefile

@@ -9,3 +9,7 @@ ifeq ($(CONFIG_BPF_SYSCALL),y)
 netdevsim-objs += \
 	bpf.o
 endif
+
+ifneq ($(CONFIG_NET_DEVLINK),)  

Hm.  Don't you need MAY_USE_DEVLINK dependency perhaps?  

mlxsw uses CONFIG_NET_DEVLINK in its Makefile.

MAY_USE_DEVLINK seems to only be used in Kconfig files. Not clear to me
why it is needed at all.

NETDEVSIM=y && DEVLINK=m

ok. I purposely did not add DEVLINK as a dependency to netdevsim to make
the resource controller truly optional. Can add it if you prefer.