Thread (3 messages) 3 messages, 3 authors, 2018-02-13

Re: [PATCH] igb: Fix a test with HWTSTAMP_TX_ON

flat view

From: Richard Cochran <richardcochran@gmail.com>
Date: 2018-02-06 21:06:58
Also in: intel-wired-lan, kernel-janitors, lkml

On Tue, Feb 06, 2018 at 08:47:59PM +0100, Christophe JAILLET wrote:
'HWTSTAMP_TX_ON' should be handled as a value, not as a bit mask.
The modified code should behave the same, because HWTSTAMP_TX_ON is 1
and no other possible values of 'tx_type' would match the test.
However, this is more future-proof, should other values be allowed one day.
Nice catch, and I am going to introduce more tx_type values soon.

Thanks,
Richard
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help