Re: [PATCH net-next] team: Use extack to report enslavement failures
From: David Ahern <hidden>
Date: 2018-02-27 16:37:25
From: David Ahern <hidden>
Date: 2018-02-27 16:37:25
On 2/27/18 8:38 AM, Ido Schimmel wrote:
Use extack inside team's enslavement function and also propagate it to
the netdevice notifier to allow enslaved ports to report the failure
reason. Example:
$ teamd -t team0 -d -c '{"runner": {"name": "lacp"}}'
$ ip link set dev lo master team0
Error: Loopback device can't be added as a team port.
Signed-off-by: Ido Schimmel <redacted>
Acked-by: Jiri Pirko <redacted>
---
drivers/net/team/team.c | 16 +++++++++++-----
1 file changed, 11 insertions(+), 5 deletions(-)LGTM. Acked-by: David Ahern [off-list ref]