On Tue, Feb 27, 2018 at 08:42:35PM +0100, Jiri Benc wrote:

On Tue, 27 Feb 2018 17:38:08 +0200, Ido Schimmel wrote:

quoted

 	if (port_dev->flags & IFF_LOOPBACK) {
+		NL_SET_ERR_MSG(extack, "Loopback device can't be added as a team port");
 		netdev_err(dev, "Device %s is loopback device. Loopback devices can't be added as a team port\n",
 			   portname);

Aren't the netdev_errs unnecessary now?

Or do you keep them for people using old config tools with a new kernel?

Yes, that's the intention. I checked bond that was also converted to use
extack and the same thing happens there.

If so, for how long? They should certainly be removed eventually. How
do we ensure we don't forget?

Seems to me it would be better to remove them right now.

I can do that unless someone objects.