Re: [PATCH RFC net-next 02/20] vrf: Move fib6_table into net_vrf
From: David Miller <hidden>
Date: 2018-02-26 20:34:16
From: David Miller <hidden>
Date: 2018-02-26 20:34:16
From: David Ahern <redacted> Date: Mon, 26 Feb 2018 13:13:24 -0700
On 2/26/18 12:08 PM, David Miller wrote:quoted
From: David Ahern <redacted> Date: Sun, 25 Feb 2018 11:47:12 -0800quoted
A later patch removes rt6i_table from rt6_info. Save the ipv6 table for a VRF in net_vrf. fib tables can not be deleted so no reference counting or locking is required. Signed-off-by: David Ahern <redacted>Is this change really OK all by itself?should. When you look at references to rt6i_table the only one for the data path is changing sernum when inserting an exception. Exceptions are not relevant for this special VRF dst as it is used for an internal redirection before packets leave the box.
...
But if you want me to be extra cautious I can leave the rt6i_table setting and remove it in patch 20 (remove unneeded rt6_info elements).
No, it's not necessary if it is really an isolated object like this.