Re: [PATCH RFC net-next 01/20] net: Move fib_convert_metrics to dst core
From: David Ahern <hidden>
Date: 2018-02-26 20:07:30
From: David Ahern <hidden>
Date: 2018-02-26 20:07:30
On 2/26/18 12:05 PM, David Miller wrote:
From: David Ahern <redacted> Date: Sun, 25 Feb 2018 11:47:11 -0800quoted
diff --git a/net/core/dst.c b/net/core/dst.c index 007aa0b08291..5f70bc832bec 100644 --- a/net/core/dst.c +++ b/net/core/dst.c...quoted
+ val = tcp_ca_get_key_by_name(net, tmp, &ecn_ca); + if (val == TCP_CA_UNSPEC) + return -EINVAL;This makes the networking core depend upon CONFIG_INET. You will have to untangle this somehow before your final submission. Probably with an inline helper in the non-INET case that always returns TCP_CA_UNSPEC.
good point. Perhaps net/ipv4/metrics.c is a better place for it given that ipv4/ipv6 common code appears to be under net/ipv4. I need to play with the config build permutations.