Re: [PATCH net] netfilter: xt_hashlimit: do not allow empty names

On Fri, Feb 02, 2018 at 01:12:08PM +0100, Jan Engelhardt wrote:

On Friday 2018-02-02 12:55, Pablo Neira Ayuso wrote:

quoted

On Fri, Feb 02, 2018 at 12:49:38PM +0100, Pablo Neira Ayuso wrote:
[...]

quoted

bool net_valid_name(const char *name, size_t len)
{
        ...
}

Am I missing anything in all these tricky string handling? Thanks!

One will have to watch out for calls like

	net_valid_name(NLA_DATA(some_ifla_name), IFNAMSIZ)

because quite some nlattrs (IFLA_NAME, IFLA_IFNAME to boot) are NLA_STRINGs
(rather than NLA_NUL_STRINGs) and they are not \0-terminated.

As long as we use nla_str*() helpers, we're all good.