Thread (9 messages) flat view 9 messages, 2 authors, 2018-01-16

Re: [Patch net v3] tun: fix a memory leak for tfile->tx_array

From: Cong Wang <hidden>
Date: 2018-01-16 06:07:58

On Mon, Jan 15, 2018 at 10:00 PM, Jason Wang [off-list ref] wrote:
I mean we can leave __tun_detach() as is, and just add the cleanup to
tun_detach_all(). This is because in both cases, we're sure skb array has
been initialized before.
Oh, I thought the same before sending v3, but I believe it is easier to
understand 'if (tfile->tx_array.ring.queue)' than 'if (tun)', because tx_array
only depends on itself rather tfile->tun in this way.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help