Re: [Patch net v3] tun: fix a memory leak for tfile->tx_array

On 2018年01月16日 13:49, Cong Wang wrote:

On Mon, Jan 15, 2018 at 9:46 PM, Jason Wang [off-list ref] wrote:

quoted

I think then you don't even need the memset trick since we are sure it has
been implemented?

It doesn't look like sk_alloc() zero's the memory of tfile.

Typo, for "implemented" I mean "initialized".

I mean we can leave __tun_detach() as is, and just add the cleanup to 
tun_detach_all(). This is because in both cases, we're sure skb array 
has been initialized before.

Thanks