Re: [PATCH 3/4] libbpf: break loop earlier

On 12/27/2017 09:30 PM, Eric Leblond wrote:

On Wed, 2017-12-27 at 11:00 -0800, Alexei Starovoitov wrote:

quoted

On Wed, Dec 27, 2017 at 07:02:28PM +0100, Eric Leblond wrote:

quoted

Get out of the loop when we have a match.

Signed-off-by: Eric Leblond <redacted>
---
 tools/lib/bpf/libbpf.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c
index 5fe8aaa2123e..d263748aa341 100644
--- a/tools/lib/bpf/libbpf.c
+++ b/tools/lib/bpf/libbpf.c

@@ -412,6 +412,7 @@ bpf_object__init_prog_names(struct bpf_object

*obj)
 					   prog->section_name);
 				return -LIBBPF_ERRNO__LIBELF;
 			}
+			break;

why this is needed?

It was just cosmetic, no related bug.

quoted

The top of the loop is:
 for (si = 0; si < symbols->d_size / sizeof(GElf_Sym) && !name;

so as soon as name is found the loop will exit.

OK, I've missed that. Please disregard this patch.

Ok, please respin the series one last time w/o this patch then.

Please also keep the already given ACKs on the other patches.

Thanks, Eric!