Re: [PATCH 3/4] libbpf: break loop earlier
From: Alexei Starovoitov <hidden>
Date: 2017-12-27 19:00:46
Also in:
lkml
On Wed, Dec 27, 2017 at 07:02:28PM +0100, Eric Leblond wrote:
quoted hunk ↗ jump to hunk
Get out of the loop when we have a match. Signed-off-by: Eric Leblond <redacted> --- tools/lib/bpf/libbpf.c | 1 + 1 file changed, 1 insertion(+)diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c index 5fe8aaa2123e..d263748aa341 100644 --- a/tools/lib/bpf/libbpf.c +++ b/tools/lib/bpf/libbpf.c@@ -412,6 +412,7 @@ bpf_object__init_prog_names(struct bpf_object *obj) prog->section_name); return -LIBBPF_ERRNO__LIBELF; } + break;
why this is needed? The top of the loop is: for (si = 0; si < symbols->d_size / sizeof(GElf_Sym) && !name; so as soon as name is found the loop will exit. I agree that the loop structure is non-standard is confusing, but adding break here will make it even more so. If 'break' is added then '&& !name' should be removed.