-----Original Message-----
From: Michael Chan [mailto:michael.chan@broadcom.com]
Sent: Thursday, December 14, 2017 2:16 AM
To: Chopra, Manish <redacted>
Cc: davem@davemloft.net; netdev@vger.kernel.org;
andrew.gospodarek@broadcom.com; Elior, Ariel [off-list ref];
Dept-Eng Everest Linux L2 [off-list ref]
Subject: Re: [PATCH net-next v4 4/5] bnx2x: Use NETIF_F_GRO_HW.

On Wed, Dec 13, 2017 at 1:08 AM, Chopra, Manish
[off-list ref] wrote:

quoted

Hi Michael,  There seems a behavioral change here. This driver support
two HW aggregation modes [LRO and GRO] With the changes, Interfaces

come with HW GRO enabled and LRO disabled by default as opposed to earlier
where interfaces used to come with LRO enabled.

Right.  Before, you had both NETIF_F_GRO and NETIF_F_LRO set and the code
looked at NETIF_F_LRO first and turned on LRO.

Now, we set NETIF_F_GRO and NETIF_F_GRO_HW by default.  NETIF_F_LRO is
turned off since NETIF_F_GRO_HW is on.

If you want, I can change it back to the old default.

Michael, I checked it on again, I tried to set LRO in dev->features and dev->hw_features.
Somehow, it gets disabled after register_netdevice().  Any idea why ? Although, I am not running any Bridge/bonding devices.
Looks like, without this series also devices seems to have LRO disabled by default.
Not sure why register_netdevice() disables LRO even driver populates this feature prior to register_netdevice().