Re: [PATCH 02/31] nds32: Kernel booting and initialization

2017-11-08 21:38 GMT+08:00 Rob Herring [off-list ref]:

On Tue, Nov 7, 2017 at 11:54 PM, Greentime Hu [off-list ref] wrote:

quoted

From: Greentime Hu <redacted>

Commit message needed.

Thanks.
I will add more commit messages in the next version patch.

quoted

Signed-off-by: Vincent Chen <redacted>
Signed-off-by: Greentime Hu <redacted>
---

quoted

+       /* it could update max_pfn */
+       if (max_pfn - ram_start_pfn <= MAXMEM_PFN)
+               max_low_pfn = max_pfn;
+       else {
+               max_low_pfn = MAXMEM_PFN + ram_start_pfn;
+#ifndef CONFIG_HIGHMEM

Use IS_ENABLED here and other ifdef's if possible.

Thanks
I will try to use IS_ENABLED here in the next version patch.

quoted

+               max_pfn = MAXMEM_PFN + ram_start_pfn;
+#endif
+       }

quoted

+static int __init nds32_device_probe(void)
+{
+       return of_platform_populate(NULL, NULL, NULL, NULL);
+}
+
+device_initcall(nds32_device_probe);

You can drop this. The core code will call of_platform_populate for you.

Thanks.
I will drop this in the next version patch.