Re: [RFC net-next 2/4] net: smsc911x: Properly manage PHY during suspend/resume
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2017-10-30 13:45:09
On Thu, Oct 26, 2017 at 1:21 AM, Florian Fainelli [off-list ref] wrote:
Commit 2aa70f864955 ("net: smsc911x: Quieten netif during suspend")
addressed the network device parts of the suspend/resume process, but
this is not enough, we can also need to manage the PHY state machine
during suspend.
Because Geert indicated that we are going to cut the power to the block,
we need the hard synchronization that phy_stop_machine() guarantees,
conversely use phy_start_machine() to resume properly.
There appears to be a desire to enable Wake-on-LAN, which is obviously
dependent on the PHY not being suspend, so we don't suspend it. A future
patch should probably add proper support for turning on/off Wake-on-LAN
on a PHY activity/password etc. basis.
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Reviewed-and-tested-by: Geert Uytterhoeven [off-list ref]
Gr{oetje,eeting}s,
Geert