Thread (13 messages) flat view 13 messages, 4 authors, 2017-10-16

Re: [PATCH net v2] net: enable interface alias removal via rtnl

From: Nicolas Dichtel <hidden>
Date: 2017-10-11 12:29:20

Le 10/10/2017 à 16:50, David Ahern a écrit :
On 10/10/17 6:41 AM, Nicolas Dichtel wrote:
quoted
IFLA_IFALIAS is defined as NLA_STRING. It means that the minimal length of
the attribute is 1 ("\0"). However, to remove an alias, the attribute
length must be 0 (see dev_set_alias()).

Let's define the type to NLA_BINARY, so that the alias can be removed.
not to be pedantic, but we need to be clear that the type is changed
only for policy validation.
With the comment in the code, it is clear, isn't it?


Regards,
Nicolas
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help