Re: [PATCH net] net: enable interface alias removal via rtnl

On 10/06/2017 08:18 PM, David Ahern wrote:

On 10/5/17 4:19 AM, Nicolas Dichtel wrote:

quoted

IFLA_IFALIAS is defined as NLA_STRING. It means that the minimal length of
the attribute is 1 ("\0"). However, to remove an alias, the attribute
length must be 0 (see dev_set_alias()).

why not add a check in dev_set_alias that if len is 1 and the 1
character is '\0' it means remove the alias?

Yes. That looks indeed better than changing NLA_STRING to NLA_BINARY 
which does not really hit the point.

Nicolas, can you send an updated patch picking up David's suggestion?

Tnx & best regards,
Oliver

quoted

Let's define the type to NLA_BINARY, so that the alias can be removed.

that changes the uapi