Re: [PATCH RFC 2/5] Add KSZ8795 switch driver support in Makefile

On Fri 2017-09-08 00:43:09, Andrew Lunn wrote:

On Thu, Sep 07, 2017 at 10:29:34PM +0000, Tristram.Ha@microchip.com wrote:

quoted

quoted

-----Original Message-----
From: Andrew Lunn [mailto:andrew@lunn.ch]
Sent: Thursday, September 07, 2017 2:56 PM
To: Tristram Ha - C24268
Cc: muvarov@gmail.com; pavel@ucw.cz; nathan.leigh.conrad@gmail.com;
vivien.didelot@savoirfairelinux.com; f.fainelli@gmail.com;
netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Woojung Huh - C21699
Subject: Re: [PATCH RFC 2/5] Add KSZ8795 switch driver support in Makefile

On Thu, Sep 07, 2017 at 09:17:10PM +0000, Tristram.Ha@microchip.com wrote:

quoted

From: Tristram Ha <redacted>

Add KSZ8795 switch support with SPI access.

Signed-off-by: Tristram Ha <redacted>
---

diff --git a/drivers/net/dsa/microchip/Makefile

b/drivers/net/dsa/microchip/Makefile

quoted

index 0961c30..0d8ba48 100644

--- a/drivers/net/dsa/microchip/Makefile
+++ b/drivers/net/dsa/microchip/Makefile

@@ -1,2 +1,4 @@
 obj-$(CONFIG_MICROCHIP_KSZ)	        += ksz9477.o ksz_common.o
 obj-$(CONFIG_MICROCHIP_KSZ_SPI_DRIVER)	+= ksz_spi.o
+obj-$(CONFIG_MICROCHIP_KSZ8795)	        += ksz8795.o ksz_common.o
+obj-$(CONFIG_MICROCHIP_KSZ8795_SPI_DRIVER)	+= ksz8795_spi.o

I've not tried it, but i think this breaks the build

     Andrew

So you would like to have all 5 patches in 1 patch file?

Or maybe this one last? Would that stop the build from breaking?

This and Kconfig change should come together.. and probably last.
									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html