Re: [PATCH RFC] Update documentation for KSZ DSA drivers so that new drivers can be added
From: Pavel Machek <hidden>
Date: 2017-09-08 09:04:41
Also in:
lkml
On Thu 2017-09-07 21:11:45, Tristram.Ha@microchip.com wrote:
From: Tristram Ha <redacted> Add other KSZ switches support so that patch check does not complain.
Nice; unlike Andrew I believe that adding compatible strings is ok before the support is added. Device tree description is Linux-independend. But... you need to Cc: device tree maintainers on this one. They usually take some time to respond, so it is nice to do this early.
quoted hunk ↗ jump to hunk
index 0ab8b39..34af0e0 100644--- a/Documentation/devicetree/bindings/net/dsa/ksz.txt +++ b/Documentation/devicetree/bindings/net/dsa/ksz.txt@@ -3,8 +3,15 @@ Microchip KSZ Series Ethernet switches Required properties: -- compatible: For external switch chips, compatible string must be exactly one - of: "microchip,ksz9477" +- compatible: Should be "microchip,ksz9477" for KSZ9477 chip, + "microchip,ksz8795" for KSZ8795 chip, + "microchip,ksz8794" for KSZ8794 chip, + "microchip,ksz8765" for KSZ8765 chip, + "microchip,ksz8895" for KSZ8895 chip, + "microchip,ksz8864" for KSZ8864 chip, + "microchip,ksz8873" for KSZ8873 chip, + "microchip,ksz8863" for KSZ8863 chip, + "microchip,ksz8463" for KSZ8463 chip See Documentation/devicetree/bindings/dsa/dsa.txt for a list of additional required and optional properties.
And you may want to wrap long line here, unless that's email client playing another trick. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Attachments
- signature.asc [application/pgp-signature] 181 bytes