Re: [PATCH net-next 2/6] net: dsa: {e}dsa: set offload_fwd_mark on received packets
From: Florian Fainelli <f.fainelli@gmail.com>
Date: 2017-09-27 19:46:41
On 09/26/2017 03:25 PM, Andrew Lunn wrote:
The software bridge needs to know if a packet has already been bridged by hardware offload to ports in the same hardware offload, in order that it does not re-flood them, causing duplicates. This is particularly true for broadcast and multicast traffic which the host has requested. By setting offload_fwd_mark in the skb the bridge will only flood to ports in other offloads and other netifs. Set this flag in the DSA and EDSA tag driver.
Is not there some kind of forwarding code/reason code being provided in the EDSA/DSA tag that tell you why this packet was sent to the CPU in the first place? What is the impact on non-broadcast traffic, e.g: multicast and unicast? Nit: I don't really have a solution on how to order patches, but until the next 4 patches get in, I suppose we temporarily have broadcast flooding by the bridge "broken"? Ordering in the opposite way would probably result in an equally bad situation so...
quoted hunk ↗ jump to hunk
Signed-off-by: Andrew Lunn <andrew@lunn.ch> --- v2 -- For the moment, do this in the tag drivers, not the generic code. Once we get more test results from other switches, maybe move it back again. --- net/dsa/tag_dsa.c | 1 + net/dsa/tag_edsa.c | 1 + 2 files changed, 2 insertions(+)diff --git a/net/dsa/tag_dsa.c b/net/dsa/tag_dsa.c index fbf9ca954773..ea6ada9d5016 100644 --- a/net/dsa/tag_dsa.c +++ b/net/dsa/tag_dsa.c@@ -154,6 +154,7 @@ static struct sk_buff *dsa_rcv(struct sk_buff *skb, struct net_device *dev, } skb->dev = ds->ports[source_port].netdev; + skb->offload_fwd_mark = 1; return skb; }diff --git a/net/dsa/tag_edsa.c b/net/dsa/tag_edsa.c index 76367ba1b2e2..a961b22a7018 100644 --- a/net/dsa/tag_edsa.c +++ b/net/dsa/tag_edsa.c@@ -173,6 +173,7 @@ static struct sk_buff *edsa_rcv(struct sk_buff *skb, struct net_device *dev, } skb->dev = ds->ports[source_port].netdev; + skb->offload_fwd_mark = 1; return skb; }
-- Florian