Thread (25 messages) flat view 25 messages, 5 authors, 2017-09-27

Re: [PATCH 6/6] net: dsa: mv88e6xxx: Forward broadcast frames to cpu and dsa ports

From: David Miller <davem@davemloft.net>
Date: 2017-09-27 03:20:22

From: Andrew Lunn <andrew@lunn.ch>
Date: Wed, 27 Sep 2017 00:26:04 +0200
+
+	for (port = 0; port < mv88e6xxx_num_ports(chip); ++port) {
Just a nit pick since you are going to respin this anyways:

	for (x; cond(x); x++)

seems to be the canonical way to express this in the kernel, so please
make "++port" into "port++"

Thank you.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help