Re: [PATCH] net: Convert int functions to bool
From: Joe Perches <joe@perches.com>
Date: 2017-09-13 22:55:53
On Thu, 2017-09-14 at 01:31 +0300, Alexey Dobriyan wrote:
quoted
Global function ipv6_rcv_saddr_equal and static functions ipv6_rcv_saddr_equal and ipv4_rcv_saddr_equal currently return int. bool is slightly more descriptive for these functions so change their return type from int to bool.From code generation POV "int" is better for non-inlined functions especially on non-x86.
I don't agree with you here. For instance: $ size net/ipv4/*.o* text data bss dec hex filename 9832 26 0 9858 2682 net/ipv4/inet_connection_sock.o.arm.defconfig.new 9860 26 0 9886 269e net/ipv4/inet_connection_sock.o.arm.defconfig.old