[iproute PATCH 0/6] strlcpy() and strlcat() for iproute2 · Phil Sutter <phil@nwl.cc> · 2017-09-01
[iproute PATCH 1/6] utils: Implement strlcpy() and strlcat() · Phil Sutter <phil@nwl.cc> · 2017-09-01
RE: [iproute PATCH 1/6] utils: Implement strlcpy() and strlcat() · David Laight <hidden> · 2017-09-04
Re: [iproute PATCH 1/6] utils: Implement strlcpy() and strlcat() · Phil Sutter <phil@nwl.cc> · 2017-09-04
Re: [iproute PATCH 1/6] utils: Implement strlcpy() and strlcat() · Stephen Hemminger <stephen@networkplumber.org> · 2017-09-04
RE: [iproute PATCH 1/6] utils: Implement strlcpy() and strlcat() · David Laight <hidden> · 2017-09-06
Re: [iproute PATCH 1/6] utils: Implement strlcpy() and strlcat() · Stephen Hemminger <stephen@networkplumber.org> · 2017-09-06
[iproute PATCH] utils: Review strlcpy() and strlcat() · Phil Sutter <phil@nwl.cc> · 2017-09-06
[iproute PATCH 4/6] ipxfrm: Replace STRBUF_CAT macro with strlcat() · Phil Sutter <phil@nwl.cc> · 2017-09-01
[iproute PATCH 2/6] Convert the obvious cases to strlcpy() · Phil Sutter <phil@nwl.cc> · 2017-09-01
Re: [iproute PATCH 2/6] Convert the obvious cases to strlcpy() · Daniel Borkmann <daniel@iogearbox.net> · 2017-09-01
[iproute PATCH 6/6] lnstat_util: Make sure buffer is NUL-terminated · Phil Sutter <phil@nwl.cc> · 2017-09-01
[iproute PATCH 5/6] tc_util: No need to terminate an snprintf'ed buffer · Phil Sutter <phil@nwl.cc> · 2017-09-01
[iproute PATCH 3/6] Convert harmful calls to strncpy() to strlcpy() · Phil Sutter <phil@nwl.cc> · 2017-09-01
Re: [iproute PATCH 0/6] strlcpy() and strlcat() for iproute2 · Stephen Hemminger <stephen@networkplumber.org> · 2017-09-01

STALE3304d

[iproute PATCH 6/6] lnstat_util: Make sure buffer is NUL-terminated

From: Phil Sutter <phil@nwl.cc>
Date: 2017-09-01 16:53:34
Subsystem: the rest · Maintainer: Linus Torvalds

Can't use strlcpy() here since lnstat is not linked against libutil.

While being at it, fix coding style in that chunk as well.

Signed-off-by: Phil Sutter <phil@nwl.cc>
---
 misc/lnstat_util.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/misc/lnstat_util.c b/misc/lnstat_util.c
index ec19238c24b94..c2dc42ec1ff12 100644
--- a/misc/lnstat_util.c
+++ b/misc/lnstat_util.c

@@ -150,7 +150,8 @@ static int lnstat_scan_compat_rtstat_fields(struct lnstat_file *lf)
 {
 	char buf[FGETS_BUF_SIZE];
 
-	strncpy(buf, RTSTAT_COMPAT_LINE, sizeof(buf)-1);
+	strncpy(buf, RTSTAT_COMPAT_LINE, sizeof(buf) - 1);
+	buf[sizeof(buf) - 1] = '\0';
 
 	return __lnstat_scan_fields(lf, buf);
 }

-- 
2.13.1