Thread (34 messages) 34 messages, 5 authors, 2017-09-02

Re: [PATCH net-next v7 01/10] selftest: Enhance kselftest_harness.h with a step mechanism

From: Alexei Starovoitov <hidden>
Date: 2017-08-26 01:07:20
Also in: linux-api, linux-security-module, lkml

On Fri, Aug 25, 2017 at 09:58:33AM +0200, Mickaël Salaün wrote:

On 24/08/2017 04:31, Alexei Starovoitov wrote:
quoted
On Mon, Aug 21, 2017 at 02:09:24AM +0200, Mickaël Salaün wrote:
quoted
This step mechanism may be useful to return an information about the
error without being able to write to TH_LOG_STREAM.

Set _metadata->no_print to true to print this counter.

Signed-off-by: Mickaël Salaün <mic@digikod.net>
Cc: Andy Lutomirski <luto@amacapital.net>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Kees Cook <redacted>
Cc: Shuah Khan <shuah@kernel.org>
Cc: Will Drewry <wad@chromium.org>
Link: https://lkml.kernel.org/r/CAGXu5j+D-FP8Kt9unNOqKrQJP4DYTpmgkJxWykZyrYiVPz3Y3Q@mail.gmail.com
---

This patch is intended to the kselftest tree:
https://lkml.kernel.org/r/20170806232337.4191-1-mic@digikod.net

Changes since v6:
* add the step counter in assert/expect macros and use _metadata to
  enable the counter (suggested by Kees Cook)
---
 tools/testing/selftests/kselftest_harness.h   | 31 ++++++++++++++++++++++-----
 tools/testing/selftests/seccomp/seccomp_bpf.c |  2 +-
 2 files changed, 27 insertions(+), 6 deletions(-)
is there a dependency on this in patches 2+ ?
if not, I would send this patch to selftests right away.
The Landlock tests [patch 9/10] rely on it for now.

I sent it three weeks ago:
https://lkml.kernel.org/r/20170806232337.4191-1-mic@digikod.net

Anyway, until this patch is merged in the kselftest tree and then
available to net-next, I'll have to keep it here.
Shuah,
could you please pick up this patch into your tree?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help