Re: [PATCH RFC 2/2] virtio_net: enable probing for NEEDS_RESET support

On Tue, Aug 29, 2017 at 04:27:41PM -0400, Willem de Bruijn wrote:

On Tue, Aug 29, 2017 at 4:16 PM, Michael S. Tsirkin [off-list ref] wrote:

quoted

On Tue, Aug 29, 2017 at 04:07:59PM -0400, Willem de Bruijn wrote:

quoted

From: Willem de Bruijn <willemb@google.com>

Implement a mechanism to signal that a virtio device implements the
VIRTIO_CONFIG_S_NEEDS_RESET command.

Testing for VIRTIO_CONFIG_S_NEEDS_RESET support by issuing the request
and verifying the reset state would require an expensive state change.

To avoid that, add a status bit to the feature register used during
feature negotiation between host and guest.

Set the bit for virtio-net, which supports the feature.

Signed-off-by: Willem de Bruijn <willemb@google.com>

All virtio 1 devices have the reset feature

I don't quite follow. No device drivers implement this request currently?

Depends. Spec 1.0 describes the bit and that driver can respond
by reseting the device. You seem to do something else
in this patchset, but as designed in 1.0 it does not seem to need
a feature bit.

quoted

so maybe guest does
not need this flag. Does device need it? Does device really
care that guest can't recover?

If all device drivers support it, then the flag is not needed.

But as long as legacy device drivers can exist that do not support
this feature, it has to have a way of differentiating between the two.

Why? Device won't set this unless it's in a bad state. In that case,
setting the bit is harmless even if drivers ignore it.

-- 
MST