Re: [PATCH net-next v1 05/14] amd-xgbe: Add additional debugfs support

On 8/18/2017 12:02 AM, David Miller wrote:

From: Andrew Lunn <andrew@lunn.ch>
Date: Fri, 18 Aug 2017 02:30:57 +0200

quoted

On Thu, Aug 17, 2017 at 07:02:50PM -0500, Tom Lendacky wrote:

quoted

Add additional debugfs support for reading / writing registers of any
attached external phy devices as well as the SFP eeprom data.

Hi Tom

What is wrong with using the standard APIs for this?

ethtool --moduile-info

ioctls SIOCGMIIREG and SIOCSMIIREG.

Yeah debugfs is a horrible choice for this.

debugfs in general should be strongly avoided.  We have rich eneough
facilities to export just about anything that is actually appropriate
and useful, and where we do not existing facilities should be extended
as needed rather than ignored.

I was intending this to be purely debugging and that's why I chose
debugfs as opposed to ethtool.  I can switch over to using ethtool
though.  I'll resubmit the series without this patch and look at
moving to this to ethtool as a separate patch later.

Thanks,
Tom