Re: [PATCH net-next v1 05/14] amd-xgbe: Add additional debugfs support
flat view
From: David Miller <davem@davemloft.net>
Date: 2017-08-18 05:02:04
From: Andrew Lunn <andrew@lunn.ch> Date: Fri, 18 Aug 2017 02:30:57 +0200
On Thu, Aug 17, 2017 at 07:02:50PM -0500, Tom Lendacky wrote:quoted
Add additional debugfs support for reading / writing registers of any attached external phy devices as well as the SFP eeprom data.Hi Tom What is wrong with using the standard APIs for this? ethtool --moduile-info ioctls SIOCGMIIREG and SIOCSMIIREG.
Yeah debugfs is a horrible choice for this. debugfs in general should be strongly avoided. We have rich eneough facilities to export just about anything that is actually appropriate and useful, and where we do not existing facilities should be extended as needed rather than ignored.