From: Florian Fainelli

Sent: 28 July 2017 18:05

...

quoted

quoted

quoted

quoted

+EXPORT_SYMBOL(lan9303_indirect_phy_ops);

Isn't EXPORT_SYMBOL_GPL prefered over EXPORT_SYMBOL?

I have no opinion. I just used the same variant as the other EXPORTS
in the file.

If there is no concern from others about this, LGTM too:

Since the kernel module license is GPL, EXPORT_SYMBOL_GPL() would seem
to be appropriate, which can be done as a subsequent patch.

It depends on whether the function needs to be usable by 'out of tree'
non-GPL modules.
This looks like a 'private' export between related modules.
The problems arise with functions like put_ns() and put_pid()
which can easily be needed by non-GPL code.

	David