Thread (19 messages) 19 messages, 5 authors, 2017-07-31

Re: [PATCH 0/3] net-next: stmmac: support future possible different internal phy mode

From: Andrew Lunn <hidden>
Date: 2017-07-28 13:55:53
Also in: linux-arm-kernel, linux-devicetree, lkml

On Fri, Jul 28, 2017 at 11:28:15AM +0200, Corentin Labbe wrote:
Hello

The current way to find if the phy is internal is to compare DT phy-mode
and emac_variant/internal_phy.
But it will negate a possible future SoC where an external PHY use the
same phy mode than the internal one.

This patchs series adds a new way to find if the PHY is internal, via its
compatible.
http://elixir.free-electrons.com/linux/latest/source/drivers/of/of_mdio.c#L144

Since you also have "ethernet-phy-ieee802.3-c22", you won't get the
warning. But still, your device tree gives the wrong idea.

I've probably asked this before: Does the internal PHY use a different
PHY ID in registers 2 and 3?

    Andrew
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help