Re: [patch net-next 04/20] net: sched: use tcf_exts_has_actions in tcf_exts_exec

[patch net-next 00/20] net: sched: summer cleanup part 1, mainly in exts area · Jiri Pirko <jiri@resnulli.us> · 2017-07-28
[patch net-next 01/20] net: sched: sch_atm: use Qdisc_class_common structure · Jiri Pirko <jiri@resnulli.us> · 2017-07-28
Re: [patch net-next 01/20] net: sched: sch_atm: use Qdisc_class_common structure · Jamal Hadi Salim <jhs@mojatatu.com> · 2017-07-30
[patch net-next 02/20] net: sched: remove unneeded tcf_em_tree_change · Jiri Pirko <jiri@resnulli.us> · 2017-07-28
[patch net-next 03/20] net: sched: change names of action number helpers to be aligned with the rest · Jiri Pirko <jiri@resnulli.us> · 2017-07-28
Re: [patch net-next 03/20] net: sched: change names of action number helpers to be aligned with the rest · Jamal Hadi Salim <jhs@mojatatu.com> · 2017-07-30
[patch net-next 04/20] net: sched: use tcf_exts_has_actions in tcf_exts_exec · Jiri Pirko <jiri@resnulli.us> · 2017-07-28
Re: [patch net-next 04/20] net: sched: use tcf_exts_has_actions in tcf_exts_exec · Jamal Hadi Salim <jhs@mojatatu.com> · 2017-07-30
Re: [patch net-next 04/20] net: sched: use tcf_exts_has_actions in tcf_exts_exec · Jiri Pirko <jiri@resnulli.us> · 2017-07-31
Re: [patch net-next 04/20] net: sched: use tcf_exts_has_actions in tcf_exts_exec · Jamal Hadi Salim <jhs@mojatatu.com> · 2017-07-31
Re: [patch net-next 04/20] net: sched: use tcf_exts_has_actions in tcf_exts_exec · Jiri Pirko <jiri@resnulli.us> · 2017-07-31
Re: [patch net-next 04/20] net: sched: use tcf_exts_has_actions in tcf_exts_exec · Cong Wang <hidden> · 2017-07-31
Re: [patch net-next 04/20] net: sched: use tcf_exts_has_actions in tcf_exts_exec · Jiri Pirko <jiri@resnulli.us> · 2017-08-01
[patch net-next 05/20] net: sched: remove redundant helpers tcf_exts_is_predicative and tcf_exts_is_available · Jiri Pirko <jiri@resnulli.us> · 2017-07-28
[patch net-next 06/20] net: sched: fix return value of tcf_exts_exec · Jiri Pirko <jiri@resnulli.us> · 2017-07-28
[patch net-next 07/20] net: sched: remove check for number of actions in tcf_exts_exec · Jiri Pirko <jiri@resnulli.us> · 2017-07-28
[patch net-next 08/20] net: sched: use tcf_exts_has_actions instead of exts->nr_actions · Jiri Pirko <jiri@resnulli.us> · 2017-07-28
[patch net-next 09/20] net: sched: convert actions array into rcu list · Jiri Pirko <jiri@resnulli.us> · 2017-07-28
Re: [patch net-next 09/20] net: sched: convert actions array into rcu list · Jamal Hadi Salim <jhs@mojatatu.com> · 2017-07-30
Re: [patch net-next 09/20] net: sched: convert actions array into rcu list · Cong Wang <hidden> · 2017-07-31
Re: [patch net-next 09/20] net: sched: convert actions array into rcu list · Jiri Pirko <jiri@resnulli.us> · 2017-08-01
[patch net-next 10/20] net: sched: cls_bpf: rename cls_bpf_modify_existing function · Jiri Pirko <jiri@resnulli.us> · 2017-07-28
Re: [patch net-next 10/20] net: sched: cls_bpf: rename cls_bpf_modify_existing function · Daniel Borkmann <daniel@iogearbox.net> · 2017-07-31
[patch net-next 11/20] net: sched: cls_fw: rename fw_change_attrs function · Jiri Pirko <jiri@resnulli.us> · 2017-07-28
[patch net-next 12/20] net: sched: cls_flower: no need to call tcf_exts_change for newly allocated struct · Jiri Pirko <jiri@resnulli.us> · 2017-07-28
[patch net-next 13/20] net: sched: cls_fw: no need to call tcf_exts_change for newly allocated struct · Jiri Pirko <jiri@resnulli.us> · 2017-07-28
[patch net-next 14/20] net: sched: cls_matchall: no need to call tcf_exts_change for newly allocated struct · Jiri Pirko <jiri@resnulli.us> · 2017-07-28
[patch net-next 15/20] net: sched: cls_basic: no need to call tcf_exts_change for newly allocated struct · Jiri Pirko <jiri@resnulli.us> · 2017-07-28
[patch net-next 16/20] net: sched: cls_bpf: no need to call tcf_exts_change for newly allocated struct · Jiri Pirko <jiri@resnulli.us> · 2017-07-28
Re: [patch net-next 16/20] net: sched: cls_bpf: no need to call tcf_exts_change for newly allocated struct · Daniel Borkmann <daniel@iogearbox.net> · 2017-07-31
[patch net-next 17/20] net: sched: cls_cgroup: no need to call tcf_exts_change for newly allocated struct · Jiri Pirko <jiri@resnulli.us> · 2017-07-28
[patch net-next 18/20] net: sched: cls_flow: no need to call tcf_exts_change for newly allocated struct · Jiri Pirko <jiri@resnulli.us> · 2017-07-28
[patch net-next 19/20] net: sched: cls_route: no need to call tcf_exts_change for newly allocated struct · Jiri Pirko <jiri@resnulli.us> · 2017-07-28
[patch net-next 20/20] net: sched: cls_u32: no need to call tcf_exts_change for newly allocated struct · Jiri Pirko <jiri@resnulli.us> · 2017-07-28
Re: [patch net-next 00/20] net: sched: summer cleanup part 1, mainly in exts area · David Miller <davem@davemloft.net> · 2017-07-31

From: Jiri Pirko <jiri@resnulli.us>
Date: 2017-07-31 06:36:16

Sun, Jul 30, 2017 at 09:48:24PM CEST, jhs@mojatatu.com wrote:

I am probably missing something. All those changes to just
replace "if (exts->nr_actions)" with "if (tcf_exts_has_actions(exts))" ?

That is what the description says :)

cheers,
jamal

On 17-07-28 10:40 AM, Jiri Pirko wrote:

quoted

From: Jiri Pirko <redacted>

Use the tcf_exts_has_actions helper instead or directly testing
exts->nr_actions in tcf_exts_exec.

Signed-off-by: Jiri Pirko <redacted>

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help