On Fri, 28 Jul 2017 07:35:07 +0200, Jiri Pirko wrote:

quoted

+enum {
+	NETDEV_PORT_EXTERNAL,
+	NETDEV_PORT_EXTERNAL_SPLIT,
+	NETDEV_PORT_PCI_PF,  

Isn't PF also EXTERNAL? Cant VF be split? What I'm getting at, shoudn't
these be flags?

By external PF do you mean not connected to the current host?  Yes we
could make a flag like that.  Right now I have picked "external" to
avoid too specific names like MAC/PHY/Ethernet...  There could be a
MAC-to-MAC connection for instance, so no PHY involved.  Should we go
with NETDEV_PORT_ETH?

I will make SPLIT into a flag.