Thread (5 messages) 5 messages, 4 authors, 2017-06-13

Re: [PATCH][netdev-next] net: hns: make guid hns_dsaf_acpi_dsm_guid static

flat view

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: 2017-06-13 14:16:50
Also in: kernel-janitors, lkml

On Tue, 2017-06-13 at 14:03 +0100, Colin King wrote:
From: Colin Ian King <redacted>

The guid hns_dsaf_acpi_dsm_guid does not need to be in global
scope, so make it static.

Cleans up sparse warning:
"symbol 'hns_dsaf_acpi_dsm_guid' was not declared. Should it be
static?"
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
quoted hunk ↗ jump to hunk
Signed-off-by: Colin Ian King <redacted>
---
 drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c
b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c
index 6b15a507999c..7a8addda726e 100644
--- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c
+++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c
@@ -29,7 +29,7 @@ enum _dsm_rst_type {
 	HNS_ROCE_RESET_FUNC     = 0x7,
 };
 
-const guid_t hns_dsaf_acpi_dsm_guid =
+static const guid_t hns_dsaf_acpi_dsm_guid =
 	GUID_INIT(0x1A85AA1A, 0xE293, 0x415E,
 		  0x8E, 0x28, 0x8D, 0x69, 0x0A, 0x0F, 0x82, 0x0A);
 
-- 
Andy Shevchenko [off-list ref]
Intel Finland Oy
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help