[PATCH][netdev-next] net: hns: make guid hns_dsaf_acpi_dsm_guid static

Subsystems: hisilicon network subsystem driver, networking drivers, the rest

STALE3412d

5 messages, 4 authors, 2017-06-13 · open the first message on its own page

[PATCH][netdev-next] net: hns: make guid hns_dsaf_acpi_dsm_guid static

From: Colin King <hidden>
Date: 2017-06-13 13:03:45

From: Colin Ian King <redacted>

The guid hns_dsaf_acpi_dsm_guid does not need to be in global
scope, so make it static.

Cleans up sparse warning:
"symbol 'hns_dsaf_acpi_dsm_guid' was not declared. Should it be static?"

Signed-off-by: Colin Ian King <redacted>
---
 drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c
index 6b15a507999c..7a8addda726e 100644
--- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c
+++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c
@@ -29,7 +29,7 @@ enum _dsm_rst_type {
 	HNS_ROCE_RESET_FUNC     = 0x7,
 };
 
-const guid_t hns_dsaf_acpi_dsm_guid =
+static const guid_t hns_dsaf_acpi_dsm_guid =
 	GUID_INIT(0x1A85AA1A, 0xE293, 0x415E,
 		  0x8E, 0x28, 0x8D, 0x69, 0x0A, 0x0F, 0x82, 0x0A);
 
-- 
2.11.0

Re: [PATCH][netdev-next] net: hns: make guid hns_dsaf_acpi_dsm_guid static

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: 2017-06-13 14:16:50

On Tue, 2017-06-13 at 14:03 +0100, Colin King wrote:
From: Colin Ian King <redacted>

The guid hns_dsaf_acpi_dsm_guid does not need to be in global
scope, so make it static.

Cleans up sparse warning:
"symbol 'hns_dsaf_acpi_dsm_guid' was not declared. Should it be
static?"
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
quoted hunk
Signed-off-by: Colin Ian King <redacted>
---
 drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c
b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c
index 6b15a507999c..7a8addda726e 100644
--- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c
+++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c
@@ -29,7 +29,7 @@ enum _dsm_rst_type {
 	HNS_ROCE_RESET_FUNC     = 0x7,
 };
 
-const guid_t hns_dsaf_acpi_dsm_guid =
+static const guid_t hns_dsaf_acpi_dsm_guid =
 	GUID_INIT(0x1A85AA1A, 0xE293, 0x415E,
 		  0x8E, 0x28, 0x8D, 0x69, 0x0A, 0x0F, 0x82, 0x0A);
 
-- 
Andy Shevchenko [off-list ref]
Intel Finland Oy

Re: [PATCH][netdev-next] net: hns: make guid hns_dsaf_acpi_dsm_guid static

From: David Miller <davem@davemloft.net>
Date: 2017-06-13 17:56:23

From: Colin King <redacted>
Date: Tue, 13 Jun 2017 14:03:21 +0100
From: Colin Ian King <redacted>

The guid hns_dsaf_acpi_dsm_guid does not need to be in global
scope, so make it static.

Cleans up sparse warning:
"symbol 'hns_dsaf_acpi_dsm_guid' was not declared. Should it be static?"

Signed-off-by: Colin Ian King <redacted>
That symbol doesn't even exist in th net-next tree.

Re: [PATCH][netdev-next] net: hns: make guid hns_dsaf_acpi_dsm_guid static

From: Andy Shevchenko <hidden>
Date: 2017-06-13 19:24:07

On Tue, Jun 13, 2017 at 8:56 PM, David Miller [off-list ref] wrote:
From: Colin King <redacted>
Date: Tue, 13 Jun 2017 14:03:21 +0100
quoted
From: Colin Ian King <redacted>

The guid hns_dsaf_acpi_dsm_guid does not need to be in global
scope, so make it static.

Cleans up sparse warning:
"symbol 'hns_dsaf_acpi_dsm_guid' was not declared. Should it be static?"

Signed-off-by: Colin Ian King <redacted>
That symbol doesn't even exist in th net-next tree.
It looks like the patch is done against UUID tree.
Cc'ed Christoph.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH][netdev-next] net: hns: make guid hns_dsaf_acpi_dsm_guid static

From: Colin Ian King <hidden>
Date: 2017-06-13 20:40:24

On 13/06/17 20:24, Andy Shevchenko wrote:
On Tue, Jun 13, 2017 at 8:56 PM, David Miller [off-list ref] wrote:
quoted
From: Colin King <redacted>
Date: Tue, 13 Jun 2017 14:03:21 +0100
quoted
From: Colin Ian King <redacted>

The guid hns_dsaf_acpi_dsm_guid does not need to be in global
scope, so make it static.

Cleans up sparse warning:
"symbol 'hns_dsaf_acpi_dsm_guid' was not declared. Should it be static?"

Signed-off-by: Colin Ian King <redacted>
That symbol doesn't even exist in th net-next tree.
It looks like the patch is done against UUID tree.
Cc'ed Christoph.
Sorry, I messed up on determining the original tree it came from in
linux-next when I looked at the output from get_maintainer.pl

Colin
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help