Thread (3 messages) 3 messages, 2 authors, 2017-06-11

Re: [PATCH net-next] vxlan: dont migrate permanent fdb entries during learn

flat view

From: Roopa Prabhu <hidden>
Date: 2017-06-11 23:26:32

On Sun, Jun 11, 2017 at 4:04 PM, David Miller [off-list ref] wrote:
From: Roopa Prabhu <redacted>
Date: Sun, 11 Jun 2017 15:51:22 -0700
quoted
From: Roopa Prabhu <redacted>

This patch fixes vxlan_snoop to not move permanent fdb entries
on learn events. This is consistent with the bridge fdb
handling of permanent entries.

Signed-off-by: Roopa Prabhu <redacted>
Is there an appropriate Fixes: tag by chance?
Just checked history. It has been that way since beginning of time.
Initial vxlan implementation (year 2012) allowed migration of any
entry via learn. A 2013 commit 26a41ae60438 ("vxlan: only migrate
dynamic FDB entries") tried to fix it, but it added a check for static
entries only (NUD_NOARP) and missed permanent entries (NUD_PERMANENT).

I think we can add:
Fixes: 26a41ae60438 ("vxlan: only migrate dynamic FDB entries")

I can re-spin with this Fixes tag.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help