From: Roopa Prabhu <redacted>
This patch fixes vxlan_snoop to not move permanent fdb entries
on learn events. This is consistent with the bridge fdb
handling of permanent entries.
Signed-off-by: Roopa Prabhu <redacted>
---
drivers/net/vxlan.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
index 7cb21a0..e045c34 100644
--- a/drivers/net/vxlan.c
+++ b/drivers/net/vxlan.c
@@ -970,7 +970,7 @@ static bool vxlan_snoop(struct net_device *dev,
return false;
/* Don't migrate static entries, drop packets */
- if (f->state & NUD_NOARP)
+ if (f->state & (NUD_PERMANENT | NUD_NOARP))
return true;
if (net_ratelimit())
--
1.9.1
From: Roopa Prabhu <redacted>
Date: Sun, 11 Jun 2017 15:51:22 -0700
From: Roopa Prabhu <redacted>
This patch fixes vxlan_snoop to not move permanent fdb entries
on learn events. This is consistent with the bridge fdb
handling of permanent entries.
Signed-off-by: Roopa Prabhu <redacted>
Is there an appropriate Fixes: tag by chance?
On Sun, Jun 11, 2017 at 4:04 PM, David Miller [off-list ref] wrote:
From: Roopa Prabhu <redacted>
Date: Sun, 11 Jun 2017 15:51:22 -0700
quoted
From: Roopa Prabhu <redacted>
This patch fixes vxlan_snoop to not move permanent fdb entries
on learn events. This is consistent with the bridge fdb
handling of permanent entries.
Signed-off-by: Roopa Prabhu <redacted>
Is there an appropriate Fixes: tag by chance?
Just checked history. It has been that way since beginning of time.
Initial vxlan implementation (year 2012) allowed migration of any
entry via learn. A 2013 commit 26a41ae60438 ("vxlan: only migrate
dynamic FDB entries") tried to fix it, but it added a check for static
entries only (NUD_NOARP) and missed permanent entries (NUD_PERMANENT).
I think we can add:
Fixes: 26a41ae60438 ("vxlan: only migrate dynamic FDB entries")
I can re-spin with this Fixes tag.