Re: [PATCH net] net: batman-adv: Fix possible memleaks when fail to register_netdevice

From: Sven Eckelmann [mailto:sven-KaDOiPu9UxWEi8DpZVb4nw@public.gmane.org]
Sent: Wednesday, April 26, 2017 1:58 PM
On Mittwoch, 26. April 2017 08:41:30 CEST Gao Feng wrote:

quoted

On Dienstag, 25. April 2017 20:03:20 CEST gfree.wind-H32Fclmsjq1BDgjK7y7TUQ@public.gmane.org wrote:

quoted

From: Gao Feng <redacted>

Because the func batadv_softif_init_late allocate some resources and
it would be invoked in register_netdevice. So we need to invoke the
func batadv_softif_free instead of free_netdev to cleanup when fail
to register_netdevice.

I could be wrong, but shouldn't the destructor be replaced with
free_netdevice and the batadv_softif_free (without the free_netdev)
used as ndo_uninit? The line you've changed should then be kept as

free_netdevice.

quoted

At least this seems to be important when using rtnl_newlink() instead
of the legacy sysfs netdev stuff from batman-adv. rtnl_newlink() would
also only call free_netdevice and thus also not run
batadv_softif_free. This seems to be only fixable by calling ndo_uninit.

Sorry, I don't get you.
The net_dev is created in this func batadv_softif_create.
Why couldn't invoke batadv_softif_free to cleanup when fail to
register_netdevice?

Because it is the legacy way to create the batadv interfaces and there is

a

"new" one. The new way is to use rtnl link (see batadv_link_ops).

The rtnl linke (rtnl_newlink) would not benefit from your fix and

therefore still

show the old behavior. I think a different fix is necessary to solve the

problem

for both ways to create an batadv interface.

Kind regards,
	Sven

I get it now, thanks.
Actually I sent another patch about the memleaks when invoke newlink and
fail to register_netdev.
You could refer to it by
https://www.mail-archive.com/netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org/msg165253.html.

In this patch, I add the cleanup when fail to register_netdev.
It would be more simple if modify the rtnl_newlink and invoke the destructor
of netdev when failed.
Like the following codes.
	if (ops->newlink) {
		err = ops->newlink(link_net ? : net, dev, tb, data);
		if (err < 0) {
			if (dev->reg_state == NETREG_UNINITIALIZED)
				if (dev->destructor)
					dev->destructor(dev)
				else
					free_netdev(dev);
				goto out;
			}
		} else {
			err = register_netdevice(dev);
			if (err < 0) {
				if (dev->destructor)
					dev->destructor(dev);
				else
					free_netdev(dev);
				goto out;
			}
	}

But I don't know if it breaks the design newlink and destructor.

BTW, I think although the batadv_softif_create is legacy, we should fix it
when it still exists :)

Regards
Feng