[PATCH net] net: lapbether: check register_netdevice_notifier() error in lapbeth_init_driver()
flat view
STALE64d
From: Minhong He <hidden>
Date: 2026-08-03 08:59:46
Also in:
lkml
Subsystem:
networking drivers, the rest, x.25 stack · Maintainers:
Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds, Martin Schiller
lapbeth_init_driver() ignores register_netdevice_notifier() errors and always returns success, which can leave the module loaded without its netdev notifier registered. Check the error and remove the packet type on failure. Signed-off-by: Minhong He <redacted> --- drivers/net/wan/lapbether.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wan/lapbether.c b/drivers/net/wan/lapbether.c
index 9861c99ea56c..c3630a82913b 100644
--- a/drivers/net/wan/lapbether.c
+++ b/drivers/net/wan/lapbether.c@@ -497,9 +497,15 @@ static const char banner[] __initconst = static int __init lapbeth_init_driver(void) { + int err; + dev_add_pack(&lapbeth_packet_type); - register_netdevice_notifier(&lapbeth_dev_notifier); + err = register_netdevice_notifier(&lapbeth_dev_notifier); + if (err) { + dev_remove_pack(&lapbeth_packet_type); + return err; + } printk(banner);
--
2.25.1